[Refactor] グローバル変数 cur_store_num を削除する #3416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
基本的に cur_store_num は現在プレイヤーが居る店舗を持つグローバル変数のようだが、
すべて引数で渡せばグローバル変数にする必要が見当たらない。
例外としてプレイヤーが店舗に居ない時に呼ばれる store_shuffle() で cur_store_num に店主入れ替えを行った店舗の番号を入れているようだが、これにしても次にプレイヤーが店舗に
入った時に更新されるので意味がなさそう。
したがってグローバル変数 cur_store_num を完全に削除する。
副作用として、グローバル変数とローカル変数の取り違いが原因で発生しているバグ #2442 も
修正される。