Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: startTimer with exemplar #593

Merged
merged 3 commits into from
Nov 25, 2023

Conversation

Pigrabbit
Copy link
Contributor

When using Histogram.startTimer() with 'enableExemplars' option set to true in order to record duration, it throws an error as following.
It supposed to work normally as it does when 'enableExemplars' option set to false.

image

Plus, it would be better if we could provide adding exemplarLabels just like we could do with Histogram.observe().

I have added the feature with regarding test cases. Please feel free to give me any feedback.

@Pigrabbit Pigrabbit changed the title Feature/start timer with exemplar feat: startTimer with exemplar Oct 24, 2023
@zbjornson zbjornson force-pushed the feature/start-timer-with-exemplar branch from 7716995 to 24f7303 Compare November 25, 2023 05:23
Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this looks perfect!

I just rebased (and added a changelog entry along the way) to try to get CI to run. I'm missing the button to authorize it for some reason, but all the checks pass locally.

@zbjornson
Copy link
Collaborator

Heh, there it goes.

@zbjornson zbjornson merged commit 1bc99bd into siimon:master Nov 25, 2023
10 checks passed
@SimenB
Copy link
Collaborator

SimenB commented Dec 15, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants