Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mark hash argument as required. #644

Merged

Conversation

kommendorkapten
Copy link
Member

Summary

The hash hash argument a default value, which is documented. The mark required call broke this as it forces the caller to actually provide the hash algorithm

Release Note

  • --hash argument to the timestamp-cli timestamp command is now optional as the documentation explains

Documentation

n/a

The hash hash argument a default value, which is documented. The mark
required call broke this as it forces the caller to actually provide
the hash algorithm

Signed-off-by: Fredrik Skogman <kommendorkapten@github.com>
@kommendorkapten kommendorkapten requested a review from a team as a code owner February 22, 2024 09:53
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fd19b0) 52.85% compared to head (7969f71) 54.85%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   52.85%   54.85%   +1.99%     
==========================================
  Files          20       20              
  Lines        1209      948     -261     
==========================================
- Hits          639      520     -119     
+ Misses        509      367     -142     
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper haydentherapper merged commit 755991c into sigstore:main Feb 22, 2024
8 checks passed
@kommendorkapten kommendorkapten deleted the fix-timestamp-hash-param branch February 22, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants