Cosign | Add support for client to configure a proxy to pull signatures #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
force-pushed
the
feat-proxy
branch
from
a3df3d1
to
a48a0db
Compare
maarrat
approved these changes
Sep 27, 2024
maarrat
approved these changes
Sep 27, 2024
maarrat
approved these changes
Sep 27, 2024
maarrat
approved these changes
Sep 27, 2024
maarrat
approved these changes
Sep 27, 2024
Xynnn007
force-pushed
the
feat-proxy
branch
2 times, most recently
from
89204d6
to
ae4c39f
Compare
|
Hi @flavio Could you please help to take a look upon this PR? |
jku
reviewed
Oct 14, 2024
flavio
reviewed
Oct 14, 2024
oci-client is the succeeder of oci-distribution crate. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
The new `https_proxy` and `no_proxy` option gives ability for the users to set a proxy to pull signature manifest from the registry. This is useful in some cases where access to the registry depends on a proxy. Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
flavio
reviewed
Oct 15, 2024
flavio
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still in draft. We will wait for a new release ofoci-clientto include oras-project/rust-oci-client#160Summary
In some special cases, client needs to connect a proxy to pull signature via a proxy. This PR mainly accomplishes this.
Release Note
ClientConfigoci-distributiontooci-clientDocumentation
TODO