fix: allow ManualTrustRoot to have multiple rekor keys #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavio
force-pushed
the
manual-trust-root-can-have-multiple-rekor-keys
branch
from
86aedb5
to
9fecd7c
Compare
|
@Xynnn007 this is ready for another round of review |
`ManualTrustRoot` implements the `TrustRoot` trait, which requires the implemented to have multiple rekor keys. The `ManualTrustRoot` struct has now been updated to handle that, prior to that only one Rekor key was stored inside of a `ManualTrustRoot` instance. Signed-off-by: Flavio Castelli <fcastelli@suse.com>
flavio
force-pushed
the
manual-trust-root-can-have-multiple-rekor-keys
branch
from
9fecd7c
to
1686be8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManualTrustRootimplements theTrustRoottrait, which requires the implemented to have multiple rekor keys. TheManualTrustRootstruct has now been updated to handle that, prior to that only one Rekor key was stored inside of aManualTrustRootinstance.