Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade ed25519-dalek to 2.0.0-rc.2 #263

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented May 19, 2023

Summary

Update ed25519-dalek dependency to 2.0.0-rc.2 with the necessary code and Cargo.toml adjustments.

Some formatting changes in Cargo.toml are done automatically by VSCode (breaking longer lines into multiple ones), here are the "real" changes of the dependencies:

- ed25519 = { version = "=2.1", features = ["alloc"] }
- ed25519-dalek = { version = "2.0.0-pre.0", features = ["pkcs8", "rand_core"] }
+ ed25519 = { version = "2.2.1", features = ["alloc"] }
+ ed25519-dalek = { version = "2.0.0-rc.2", features = ["pkcs8", "rand_core"] }
[...]
+ spki = { version = "0.7.2", features = ["pem", "std"] }

Closes #262.

Release Suggestion

Since this would be changing dependencies, it may be worth to cut a "checkpoint" 0.6.1 release before merging this PR.

Release Note

  • updated dependencies: ed25519-dalek to 2.0.0-rc.2 and ed25519 - to 2.2.1.

Documentation

No changes.

@dmitris dmitris force-pushed the ed25519-upd branch 2 times, most recently from af8f402 to 40881ea Compare May 22, 2023 14:15
Upgrade ed25519 from 2.1 to 2.2.1 and ed25519-dalek
from 2.0.0-pre.0 to 2.0.0-rc.2 with necessary code adjustments.

Closes sigstore#262.

Signed-off-by: Dmitry S <dsavints@gmail.com>
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, thanks for this update. It was on my TODO list since a long time

@flavio
Copy link
Member

flavio commented May 25, 2023

Since this would be changing dependencies, it may be worth to cut a "checkpoint" 0.6.1 release before merging this PR.

I think we cannot do that, since we've already merged some breaking API changes into the main branch.

I would merge this PR, take a look at the remaining deps that need to be updated and then cut a 0.7 release.

How do the other @sigstore/sigstore-rs-codeowners feel about that?

@flavio
Copy link
Member

flavio commented May 25, 2023

Cool, merging based on the reaction of the other maintainers

@flavio flavio merged commit 0bab41c into sigstore:main May 25, 2023
@dmitris dmitris deleted the ed25519-upd branch May 25, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update crate dependencies - ed25519-dalek and ed25519
2 participants