Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace x509-parser with x509-cert #212

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Replace x509-parser with x509-cert #212

merged 1 commit into from
Feb 13, 2023

Conversation

Xynnn007
Copy link
Member

Summary

Replace x509-parser with x509-cert.

Release Note

  • x509-cert is from RustCrypto, and the replaced x509-parser depends on ring. This PR will help to get rid of ring.
  • Add a test that converts a public key cert of ed25519 into a CosignVerificationKey

@Xynnn007
refactor: replace x509-parser with x509-cert
3d5f256 
x509-cert is from RustCrypto, this replacement will
help to get rid of `ring` dependency.

Signed-off-by: Xynnn007 <xynnn@linux.alibaba.com>
@Xynnn007 Xynnn007 requested a review from flavio February 13, 2023 09:40
flavio
flavio approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's super nice! Feel free to merge this PR anytime you want

@Xynnn007 Xynnn007 merged commit bb68d37 into sigstore:main Feb 13, 2023
@Xynnn007 Xynnn007 deleted the refactor-x509-cert branch February 14, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio flavio flavio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xynnn007 @flavio