Changed the type of LogEntry.body from String to Body #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Objective To enable detailed information of LogEntry.body to be obtained when LogEntry is retrieved. Change In conjunction with changing the type of LogEntry.body to Body, I added default trait for Body and the structs and enums on which it depends, using derive macro. (Body, Spec, Signature, PublicKey, Data, AlgotithmKind, Hash) In addition, in entries_api.rs, the use of serde_json::from_str was changed to the newly implemented LogEntry::from_str. LogEntry::from_str uses HashMap with &str for key and serde_json::Value for value, and body is decoded. Since a HashMap cannot be directly converted to a LogEntry, it is converted to a String with serde_json::to_string and then converted to a LogEntry with serde_json::from_str. Signed-off-by: Neccolini <shun11202991@gmail.com>
|
Errors in Clippy don't seem to be related to the changes. https://github.com/sigstore/sigstore-rs/actions/runs/4072911131/jobs/7018309114#step:5:500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neccolini shun11202991@gmail.com
closes #150
Summary
Enable detailed information to be obtained when a
LogEntryis retrieved, whereas previously only encodedStringwas available for theBodyinformation.Release Note
Documentation