Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show actual response status field #197

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Jan 23, 2023

Summary

Show the actual response status code, instead of {error.status:?}.

Currently, when a remote call fails with a client or server error, it shows a response error with the following message:

error in response: status code {{error.status:?}}

However, I do believe the actual intention (and what would be helpful), is to show the actual status code, instead of the literal string: {error.status:?}.

This PR fixes this issue, so that the error code gets shown.

Release Note

Fix an issue where, instead of the actual error code, the literal string {error.status:?} was shown.

Documentation

Signed-off-by: Jens Reimann <jreimann@redhat.com>
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@flavio flavio merged commit 3d3e786 into sigstore:main Jan 24, 2023
@ctron ctron deleted the feature/fix_error_msg_1 branch January 25, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants