Improve public key output and add file output #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gronner
force-pushed
the
output_get_public_key_example
branch
from
2219ff0 to
f406ffd
Compare
Previously Debug printing was used to output the public key after retrieval. Using Display printing the public key is displayed to the command line as expected with line breaks. In addition this commit adds --output,-o as arguments to store the retrieved public key in a file. To ease use a default value (key.pub) is provided, so that no parameter needs to be given. Resolves: #105 Signed-off-by: Gronner <felix.braeunling@t-online.de>
Gronner
force-pushed
the
output_get_public_key_example
branch
from
f406ffd to
8afc7a5
Compare
flavio
requested changes
Jan 25, 2023
| println!("{:#?}", pubkey.unwrap()); | ||
|
|
||
| if let Some(out_path) = flags.get_one::<String>("output") { | ||
| match write(out_path, pubkey.unwrap()) { |
There was a problem hiding this comment.
nitpicking: instead of using unwrap use expect with a nice message. I would do that right on line 50, after the await.
There was a problem hiding this comment.
Done, in the future it might be useful to enhance the errors get_public_key returns to enhance the possible feedback or by "unpacking" the information stored in the returned error.
Signed-off-by: Gronner <felix.braeunling@t-online.de>
Gronner
force-pushed
the
output_get_public_key_example
branch
from
b1e4166 to
bc370a4
Compare
flavio
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in #105 the output provided by the example
get_public_keywas not pretty. It included quotation marks at the beginning and the and, as well as the newline characters\n.In addition this prevented piping the output of the example into a file, as it would include the quotation marks and the newline characters. Now using
cargo run --example get_public_key > key.pubthe public key can be stored in a file in the PEM format.In addition it can be useful to directly store the public key in a file instead of piping to a file.
Release Note
The Rekor example
get_public_keywas expanded to:DisplayprintingDocumentation
Close #105