Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rustls should not require openssl #146

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

flavio
Copy link
Member

@flavio flavio commented Oct 20, 2022

Ensure the openssl dependency is not introduced when the sigstore-rs library is built using rustls-tls.

Cargo.toml Outdated Show resolved Hide resolved
Ensure the openssl dependency is not introduced when the sigstore-rs
library is built using rustls-tls.

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Copy link
Collaborator

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@viccuad viccuad merged commit 42d45f4 into sigstore:main Oct 21, 2022
@flavio flavio deleted the fix-building-with-rustls branch October 21, 2022 08:53
flavio added a commit to flavio/sigstore-rs that referenced this pull request Oct 21, 2022
Fixes
======

* rustls should not require openssl by (sigstore#146)

Others
======

* Rework Rekor module structure and enable doc tests (sigstore#145)

Contributors
============

* Flavio Castelli (@flavio)
* Lily Sturmann (@lkatalin)

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
avery-blanchard pushed a commit to avery-blanchard/sigstore-rs that referenced this pull request Oct 21, 2022
Fixes
======

* rustls should not require openssl by (sigstore#146)

Others
======

* Rework Rekor module structure and enable doc tests (sigstore#145)

Contributors
============

* Flavio Castelli (@flavio)
* Lily Sturmann (@lkatalin)

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants