-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read Fulcio certificate chain as bytes in verify command #796
Conversation
Signed-off-by: Maya Costantini <maya.costantini@protonmail.com>
/gcbrun |
This might be a good candidate for a conformance test here: https://github.com/sigstore/sigstore-conformance/blob/main/test/test_certificate_verify.py |
Thanks @mayaCostantini! Would you mind adding a fix |
f7905d5
to
e221612
Compare
Done, thanks! |
Signed-off-by: Maya Costantini <maya.costantini@protonmail.com>
e221612
to
7ae9f06
Compare
/gcbrun |
Signed-off-by: William Woodruff <william@yossarian.net>
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mayaCostantini!
@di will have to app and merge since I made a CHANGELOG
tweak.
Summary
Fixes #795
Fix opening the PEM file argument of the
--certificate-chain
option insigstore verify <identity, github>
asbytes
instead ofstr
.Release Note
None