Add GCP Pub/Sub topic for new entry events #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalseth
force-pushed
the
rekor-pubsub
branch
5 times, most recently
from
b53cb45
to
394bf36
Compare
|
/hold Will want to discuss permissions for reading topics before merging. |
jalseth
force-pushed
the
rekor-pubsub
branch
4 times, most recently
from
1b1ba34
to
b80bb4d
Compare
haydentherapper
previously approved these changes
Jan 18, 2024
There was a problem hiding this comment.
@jalseth Sorry for the way too long delay! Looks good, can you rebase to trigger tests again?
This will be used by Rekor to publish events for each new entry added to the transparency log. Signed-off-by: James Alseth <james@jalseth.me>
haydentherapper
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Terraform for a GCP Pub/Sub topic for new entry events. This will be used by Rekor to publish events for each new entry added to the transparency log.
Release Note
Documentation
N/A.
Relates to sigstore/rekor#1580