update test ctlog validFor period in trusted root #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #616
Summary
Updating the
trusted_root.json
target with the correct valid-for range on the "https://ctfe.sigstore.dev/test" ctlog entry.In an effort to get better start/end dates, I examined the first and last entries on the "test" ctlog and looked at the corresponding timestamps:
I found the first and last timestamps to be "2021-03-14T16:27:21.940Z" and "2022-10-31T19:29:48.033Z"
When setting the valid-for range for the corresponding ctlog key, I rounded that first timestamp down to the beginning of the day and rounded the last timestamp up to the end of the day.
(@haydentherapper am I on the right track here?)