Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test ctlog validFor period in trusted root #644

Merged
merged 1 commit into from
Feb 20, 2023
Merged

update test ctlog validFor period in trusted root #644

merged 1 commit into from
Feb 20, 2023

Conversation

bdehamer
Copy link
Contributor

Per #616

Summary

Updating the trusted_root.json target with the correct valid-for range on the "https://ctfe.sigstore.dev/test" ctlog entry.

In an effort to get better start/end dates, I examined the first and last entries on the "test" ctlog and looked at the corresponding timestamps:

curl "https://ctfe.sigstore.dev/test/ct/v1/get-entries?start=0&end=0"
curl "https://ctfe.sigstore.dev/test/ct/v1/get-entries?start=3533286&end=3533286"

I found the first and last timestamps to be "2021-03-14T16:27:21.940Z" and "2022-10-31T19:29:48.033Z"

When setting the valid-for range for the corresponding ctlog key, I rounded that first timestamp down to the beginning of the day and rounded the last timestamp up to the end of the day.

(@haydentherapper am I on the right track here?)

Signed-off-by: Brian DeHamer <bdehamer@github.com>
Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good but would like to hear from @haydentherapper before merging.

@haydentherapper
Copy link
Contributor

Thanks for checking! This looks good.

@haydentherapper haydentherapper merged commit d39a5fa into sigstore:main Feb 20, 2023
kommendorkapten added a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Brian DeHamer <bdehamer@github.com>
Co-authored-by: Brian DeHamer <bdehamer@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants