fix: fix targets removal so it doesn't interfere with delegations #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
|
Note: we should use this change: otherwise staging the metadata file but not utilizing/signing it will cause a failure in snapshotting. Unless we manually delete. But I'd rather not make manual changes to repository creation. |
joshuagl
previously approved these changes
Sep 28, 2022
There was a problem hiding this comment.
Note: we should use this change: otherwise staging the metadata file but not utilizing/signing it will cause a failure in snapshotting. Unless we manually delete. But I'd rather not make manual changes to repository creation.
Completely agree with this position.
LGTM
haydentherapper
previously approved these changes
Sep 28, 2022
Closed
Signed-off-by: Asra Ali <asraa@google.com>
asraa
dismissed stale reviews from haydentherapper and joshuagl
via
83ba053
haydentherapper
approved these changes
Sep 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
As a bypass for theupdateframework/go-tuf#400: which describes that
repo.RemoveTargetsWithExpiresremoves the targets from ALL roles, including delegations.Because of this, we removed
rekor.0.pubfrom the top-level targets AND the rekor delegation, staging a new version of the delegate where we did not mean to.This was noted in @joshuagl 's review: #410 (review)
Note: we have an e2e regression test for target rotation covered.
Summary
Release Note
Documentation