Disable sigstore-java test temporarily #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sigstore-java cannot handle the hashes we use * Disable the test to allow the publish to proceed Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
|
Making a draft for now to make sure we have consensus before continuing: review is still welcome |
|
Discussed with Appu, let's do this. |
kommendorkapten
approved these changes
Aug 22, 2024
|
I think this can be reverted now that we fixed: sigstore/sigstore-java#796 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#161 -- plan is to not do this (modify artifacts so that it leads to hash changes) in production in near future, but instead evaluate situation again after sigstore-java has been fixed