Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 404 if entry isn't found in log #915

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

priyawadhwa
Copy link
Contributor

Signed-off-by: Priya Wadhwa priya@chainguard.dev

Summary

Release Note

Documentation

@priyawadhwa priyawadhwa requested a review from a team as a code owner July 11, 2022 14:33
pkg/api/entries.go Outdated Show resolved Hide resolved
pkg/api/entries.go Outdated Show resolved Hide resolved
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #915 (0d1a042) into main (c962a68) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   48.22%   48.11%   -0.12%     
==========================================
  Files          62       62              
  Lines        5398     5398              
==========================================
- Hits         2603     2597       -6     
- Misses       2513     2517       +4     
- Partials      282      284       +2     
Impacted Files Coverage Δ
pkg/types/alpine/v0.0.1/entry.go 54.20% <0.00%> (-2.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c962a68...0d1a042. Read the comment docs.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @loosebazooka hit this i think

@dlorenc dlorenc merged commit 6093a33 into sigstore:main Jul 11, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Jul 11, 2022
bobcallaway pushed a commit to bobcallaway/rekor that referenced this pull request Aug 3, 2022
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants