Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get log proofs by Tree ID #733

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

priyawadhwa
Copy link
Contributor

We will need this so we can get proofs for inactive shards. This will be used by loginfo.

Signed-off-by: Priya Wadhwa priya@chainguard.dev

Summary

Ticket Link

Fixes

Release Note


@priyawadhwa priyawadhwa requested a review from a team as a code owner March 15, 2022 12:03
We will need this so we can get proofs for inactive shards. This will be used by `loginfo`.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
Copy link
Member

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dlorenc
Copy link
Member

dlorenc commented Mar 15, 2022

I'll hold for @bobcallaway and @lkatalin to take a look though.

Copy link
Contributor

@lkatalin lkatalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @priyawadhwa : )

@dlorenc dlorenc merged commit 2ab7705 into sigstore:main Mar 16, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 16, 2022
@priyawadhwa priyawadhwa deleted the logproof-treeid branch March 17, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants