Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Helm index keys #474

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Correct Helm index keys #474

merged 1 commit into from
Nov 2, 2021

Conversation

sabre1041
Copy link
Contributor

Corrections to how Helm index keys are stored

@sabre1041 sabre1041 mentioned this pull request Oct 31, 2021
Merged
dlorenc
dlorenc reviewed Nov 1, 2021
View reviewed changes
Copy link
Member

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one nit about which constant to use.

pkg/types/helm/provenance_test.go Outdated Show resolved Hide resolved
@sabre1041
Correct Helm index keys
5ca2654 
Signed-off-by: Andrew Block <andy.block@gmail.com>
@bobcallaway bobcallaway merged commit 317e88d into sigstore:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc dlorenc left review comments

@bobcallaway bobcallaway bobcallaway approved these changes

@lukehinds lukehinds Awaiting requested review from lukehinds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabre1041 @dlorenc @bobcallaway