Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validation error handling on API #2217

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

bobcallaway
Copy link
Member

Fixes: #2209

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner August 26, 2024 12:06
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 49.01961% with 26 lines in your changes missing coverage. Please review.

Project coverage is 51.41%. Comparing base (488eb97) to head (ca96b01).
Report is 184 commits behind head on main.

Files Patch % Lines
pkg/types/jar/v0.0.1/entry.go 10.00% 9 Missing ⚠️
pkg/api/entries.go 0.00% 6 Missing ⚠️
pkg/types/alpine/v0.0.1/entry.go 60.00% 2 Missing ⚠️
pkg/types/error.go 0.00% 2 Missing ⚠️
pkg/types/helm/v0.0.1/entry.go 60.00% 2 Missing ⚠️
pkg/types/rpm/v0.0.1/entry.go 66.66% 2 Missing ⚠️
pkg/types/hashedrekord/v0.0.1/entry.go 88.88% 1 Missing ⚠️
pkg/types/rekord/v0.0.1/entry.go 75.00% 1 Missing ⚠️
pkg/types/tuf/v0.0.1/entry.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2217       +/-   ##
===========================================
- Coverage   66.46%   51.41%   -15.05%     
===========================================
  Files          92      190       +98     
  Lines        9258    19470    +10212     
===========================================
+ Hits         6153    10011     +3858     
- Misses       2359     8382     +6023     
- Partials      746     1077      +331     
Flag Coverage Δ
e2etests 50.23% <0.00%> (+2.67%) ⬆️
unittests 42.99% <49.01%> (-4.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobcallaway bobcallaway merged commit c16f610 into sigstore:main Aug 26, 2024
15 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve error message from API layer
3 participants