Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trillian images from release process #1983

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

bobcallaway
Copy link
Member

now that sigstore/scaffolding#968 has landed and v0.6.16 of scaffolding has been released, we should stop building and publishing trillian as part of rekor releases.

Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's also some references in

if [[ ! -f trillianSignerImagerefs ]]; then

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63aa08f) 66.53% compared to head (d2762be) 66.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
- Coverage   66.53%   66.48%   -0.06%     
==========================================
  Files          92       92              
  Lines        9246     9246              
==========================================
- Hits         6152     6147       -5     
- Misses       2351     2355       +4     
- Partials      743      744       +1     
Flag Coverage Δ
e2etests 47.53% <ø> (ø)
unittests 47.68% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haydentherapper
Copy link
Contributor

also note we'll want to update

image: gcr.io/projectsigstore/trillian_log_server@sha256:f850a0defd089ea844822030c67ae05bc93c91168a7dd4aceb0b6648c39f696b
and related

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway
Copy link
Member Author

also note we'll want to update

image: gcr.io/projectsigstore/trillian_log_server@sha256:f850a0defd089ea844822030c67ae05bc93c91168a7dd4aceb0b6648c39f696b

and related

yup, i'll do that in a separate PR.

@bobcallaway bobcallaway merged commit 134ef83 into sigstore:main Jan 30, 2024
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants