Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a single validator library in rekor-cli #1818

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

bobcallaway
Copy link
Member

Summary

Release Note

Documentation

Signed-off-by: Bob Callaway <bcallaway@google.com>
@@ -60,13 +63,14 @@ func validateSHA256Value(v string) error {
hash = split[1]
}

s := struct {
Prefix string `validate:"omitempty,oneof=sha256"`
Hash string `validate:"required,len=64,hexadecimal"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq, i noticed on the other PR, we dropped required from required,email - is this behavior equivalent with this new library?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the check fails if the criteria isn't met

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #1818 (f667719) into main (b681a14) will increase coverage by 18.85%.
The diff coverage is 75.94%.

@@             Coverage Diff             @@
##             main    #1818       +/-   ##
===========================================
+ Coverage   47.54%   66.40%   +18.85%     
===========================================
  Files          78       90       +12     
  Lines        8260     9057      +797     
===========================================
+ Hits         3927     6014     +2087     
+ Misses       3940     2309     -1631     
- Partials      393      734      +341     
Flag Coverage Δ
e2etests 47.92% <55.69%> (?)
unittests 47.36% <67.08%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/rekor-cli/app/validate.go 100.00% <100.00%> (ø)
cmd/rekor-cli/app/pflags.go 84.46% <67.24%> (-5.85%) ⬇️

... and 62 files with indirect coverage changes

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway
Copy link
Member Author

@steiza fyi

@bobcallaway bobcallaway merged commit c3ffda6 into sigstore:main Nov 8, 2023
14 checks passed
@github-actions github-actions bot added this to the v1.2.2 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants