Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit informational message if machine-parseable output has been requested #1486

Merged
merged 1 commit into from
May 23, 2023

Conversation

bobcallaway
Copy link
Member

Fixes: #1395

…sted

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner May 12, 2023 23:19
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1486 (9487208) into main (3282e1a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
+ Coverage   64.33%   64.36%   +0.03%     
==========================================
  Files          80       80              
  Lines        7789     7790       +1     
==========================================
+ Hits         5011     5014       +3     
+ Misses       2129     2127       -2     
  Partials      649      649              
Flag Coverage Δ
e2etests 48.22% <100.00%> (+<0.01%) ⬆️
unittests 44.67% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/rekor-cli/app/search.go 58.15% <100.00%> (+0.29%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this issue exist in rekor-CLI get? If so, we should leave the ticket open

@bobcallaway
Copy link
Member Author

Does this issue exist in rekor-CLI get? If so, we should leave the ticket open

If I use --format=json on rekor-cli get, I don't see the behavior reported in #1395 - the default format isn't meant to be machine-parseable.

@bobcallaway bobcallaway merged commit 43be4d8 into sigstore:main May 23, 2023
@github-actions github-actions bot added this to the v1.1.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add "script-friendly output" flag to rekkor-cli
3 participants