-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor consistency check workflow and update docs #493
Draft
linus-sun
wants to merge
6
commits into
sigstore:main
Choose a base branch
from
linus-sun:linussun/refactor-consistency-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor consistency check workflow and update docs #493
linus-sun
wants to merge
6
commits into
sigstore:main
from
linus-sun:linussun/refactor-consistency-config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linus-sun <linussun@google.com>
Signed-off-by: linus-sun <linussun@google.com>
Signed-off-by: Linus Sun <73363182+linus-sun@users.noreply.github.com>
Signed-off-by: Linus Sun <73363182+linus-sun@users.noreply.github.com>
Signed-off-by: Linus Sun <73363182+linus-sun@users.noreply.github.com> Signed-off-by: linus-sun <linussun@google.com>
linus-sun
force-pushed
the
linussun/refactor-consistency-config
branch
from
October 18, 2024 20:40
9291b98
to
d578c6f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #493 +/- ##
==========================================
- Coverage 64.02% 60.68% -3.35%
==========================================
Files 4 15 +11
Lines 303 1175 +872
==========================================
+ Hits 194 713 +519
- Misses 78 402 +324
- Partials 31 60 +29 ☔ View full report in Codecov by Sentry. |
linus-sun
force-pushed
the
linussun/refactor-consistency-config
branch
from
October 18, 2024 20:47
d578c6f
to
f38008f
Compare
Signed-off-by: linus-sun <linussun@google.com>
linus-sun
force-pushed
the
linussun/refactor-consistency-config
branch
from
October 18, 2024 22:38
4c11417
to
ecf7077
Compare
linus-sun
changed the title
Linussun/refactor consistency config
Refactor consistency check workflow and update docs
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Per work outlined here, this updates documentation to reflect the separation of consistency check and identity monitoring as separate components. Users can view how to run the updated consistency check workflow in the updated README, using a custom configuration file. This PR also refactors the repeated portion of the workflow out into
cmd/main
, rather than the workflow function itself.This PR depends on #491 and #492. Relevant commits:
ecf7077
70f13d7
Release Note
Configuration updates to consistency check workflow
Documentation
The README has been updated accordingly.