Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor consistency check workflow and update docs #493

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

linus-sun
Copy link
Collaborator

@linus-sun linus-sun commented Oct 18, 2024

Summary

Per work outlined here, this updates documentation to reflect the separation of consistency check and identity monitoring as separate components. Users can view how to run the updated consistency check workflow in the updated README, using a custom configuration file. This PR also refactors the repeated portion of the workflow out into cmd/main, rather than the workflow function itself.

This PR depends on #491 and #492. Relevant commits:
ecf7077
70f13d7

Release Note

Configuration updates to consistency check workflow

Documentation

The README has been updated accordingly.

linus-sun and others added 5 commits October 18, 2024 17:32
Signed-off-by: linus-sun <linussun@google.com>
Signed-off-by: linus-sun <linussun@google.com>
Signed-off-by: Linus Sun <73363182+linus-sun@users.noreply.github.com>
Signed-off-by: Linus Sun <73363182+linus-sun@users.noreply.github.com>
Signed-off-by: Linus Sun <73363182+linus-sun@users.noreply.github.com>
Signed-off-by: linus-sun <linussun@google.com>
@linus-sun linus-sun force-pushed the linussun/refactor-consistency-config branch from 9291b98 to d578c6f Compare October 18, 2024 20:40
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 8.05085% with 217 lines in your changes missing coverage. Please review.

Project coverage is 60.68%. Comparing base (d271ec7) to head (ecf7077).
Report is 132 commits behind head on main.

Files with missing lines Patch % Lines
cmd/monitor/main.go 0.00% 87 Missing ⚠️
cmd/verifier/main.go 0.00% 38 Missing ⚠️
pkg/rekor/verifier.go 3.33% 29 Missing ⚠️
pkg/rekor/identity.go 40.90% 22 Missing and 4 partials ⚠️
cmd/monitor/config.go 0.00% 23 Missing ⚠️
pkg/identity/identity.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   64.02%   60.68%   -3.35%     
==========================================
  Files           4       15      +11     
  Lines         303     1175     +872     
==========================================
+ Hits          194      713     +519     
- Misses         78      402     +324     
- Partials       31       60      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linus-sun linus-sun force-pushed the linussun/refactor-consistency-config branch from d578c6f to f38008f Compare October 18, 2024 20:47
Signed-off-by: linus-sun <linussun@google.com>
@linus-sun linus-sun force-pushed the linussun/refactor-consistency-config branch from 4c11417 to ecf7077 Compare October 18, 2024 22:38
@linus-sun linus-sun changed the title Linussun/refactor consistency config Refactor consistency check workflow and update docs Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant