proto, pkg, docs: update CSR docstrings #926
Conversation
Signed-off-by: William Woodruff <william@trailofbits.com>
woodruffw
force-pushed
the
ww/csr-docs
branch
from
b5f9e86 to
2e00c43
Compare
| @@ -16,7 +16,7 @@ | |||
| // Code generated by protoc-gen-go. DO NOT EDIT. | |||
| // versions: | |||
| // protoc-gen-go v1.28.1 | |||
| // protoc v3.20.3 | |||
| // protoc v3.21.11 | |||
There was a problem hiding this comment.
Ah, this is gonna be an issue. My recommendation is to either update
fulcio/.github/workflows/main.yml
Line 41 in d1fa542
There was a problem hiding this comment.
My protoc is from brew, so downgrading might be a little painful 😅 -- I'll bump the action if that's alright.
There was a problem hiding this comment.
Hm, it seems to think that version doesn't exist.
There was a problem hiding this comment.
Yeah...looks like manifestation of this issue: arduino/setup-protoc#33
There was a problem hiding this comment.
(It seems like protobuf changed its versioning to chop the 3. prefix off, and this action doesn't know about that.)
There was a problem hiding this comment.
I opened arduino/setup-protoc#58 with a fix to that action, and I've temporarily updated this PR to pin my trail-of-forks fork instead. But I assume we'll want this to be upstreamed before merging 🙂
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
|
The diff is still failing, for reasons that aren't clear to me...is it possible |
|
@woodruffw Are you using Go 1.19.4? Differences in Go versions can also cause issues |
|
Bumped my `go` version. Signed-off-by: William Woodruff <william@trailofbits.com>
Closes #863.
Signed-off-by: William Woodruff william@trailofbits.com
cc @haydentherapper