Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github.com/google/tink/go to 1.7.0 and fix deprecation #736

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 11, 2022

Summary

  • update github.com/google/tink/go to 1.7.0 and fix deprecation

Signed-off-by: cpanato <ctadeu@gmail.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

switch {
case strings.HasPrefix(kmsKey, "gcp-kms://"):
gcpClient, err := gcpkms.NewClient(kmsKey)
gcpClient, err := gcpkms.NewClientWithOptions(ctx, kmsKey)
if err != nil {
return nil, err
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there the same NewClientWithOptions for awskms?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, not yet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for checking

@codecov-commenter
Copy link

Codecov Report

Merging #736 (55a9b13) into main (15cff3e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage   54.22%   54.22%           
=======================================
  Files          36       36           
  Lines        2248     2248           
=======================================
  Hits         1219     1219           
  Misses        936      936           
  Partials       93       93           
Impacted Files Coverage Δ
pkg/ca/tinkca/tinkca.go 37.93% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@haydentherapper haydentherapper merged commit a81df76 into sigstore:main Aug 12, 2022
@cpanato cpanato deleted the deprecated branch August 13, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants