Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure GetTrustBundle returns array of strings instead of a single string with newlines #690

Merged
merged 4 commits into from
Jul 20, 2022

Conversation

bobcallaway
Copy link
Member

Fixes: #689

Signed-off-by: Bob Callaway bcallaway@google.com

Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to changing the interface, this looks good! Left a few comments

pkg/ca/ca.go Outdated Show resolved Hide resolved
pkg/ca/ca.go Outdated Show resolved Hide resolved
pkg/ca/googleca/v1/googleca.go Outdated Show resolved Hide resolved
Signed-off-by: Bob Callaway <bcallaway@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #690 (a3fcc08) into main (8010171) will increase coverage by 0.00%.
The diff coverage is 32.60%.

@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   54.21%   54.22%           
=======================================
  Files          36       36           
  Lines        2228     2248   +20     
=======================================
+ Hits         1208     1219   +11     
- Misses        927      936    +9     
  Partials       93       93           
Impacted Files Coverage Δ
pkg/ca/googleca/v1/googleca.go 47.54% <0.00%> (-4.72%) ⬇️
pkg/server/grpc_server.go 52.17% <81.25%> (+0.65%) ⬆️
pkg/ca/baseca/baseca.go 56.09% <100.00%> (ø)
pkg/ca/fileca/watch.go 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8010171...a3fcc08. Read the comment docs.

pkg/ca/googleca/v1/googleca.go Outdated Show resolved Hide resolved
pkg/ca/googleca/v1/googleca.go Outdated Show resolved Hide resolved
pkg/ca/googleca/v1/googleca.go Show resolved Hide resolved
Signed-off-by: Bob Callaway <bcallaway@google.com>
@haydentherapper haydentherapper merged commit 6516933 into sigstore:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return cert chain in json
3 participants