Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small ca refactor #569

Merged
merged 2 commits into from
May 12, 2022
Merged

Small ca refactor #569

merged 2 commits into from
May 12, 2022

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented May 11, 2022

Summary

Slit up the the structs / interfaces in pkg/ca into seperate files and add tests for serialization / deserialization methods on CodeSigningCertificate

Release Note

NONE

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2022

Codecov Report

Merging #569 (489b83c) into main (c166938) will increase coverage by 1.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   43.13%   44.56%   +1.42%     
==========================================
  Files          20       21       +1     
  Lines        1472     1528      +56     
==========================================
+ Hits          635      681      +46     
- Misses        766      773       +7     
- Partials       71       74       +3     
Impacted Files Coverage Δ
pkg/ca/csc.go 73.21% <ø> (ø)
pkg/ca/fileca/watch.go 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c166938...489b83c. Read the comment docs.

Nathan Smith added 2 commits May 11, 2022 16:34
Moves each struct and interface into its own file

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
Signed-off-by: Nathan Smith <nathan@chainguard.dev>
@nsmith5 nsmith5 marked this pull request as ready for review May 11, 2022 23:34
@haydentherapper
Copy link
Contributor

No concerns with this, but just wondering, what's the motivation for splitting it up?

@nsmith5
Copy link
Contributor Author

nsmith5 commented May 11, 2022

I just find it a little easier to read that way, but I'm ok either way. Adding the tests is more important bit here for me

@haydentherapper
Copy link
Contributor

I don't mind either way, no strong preference between multiple files and one, especially since this isn't too much code anyways.

@dlorenc dlorenc merged commit 91b45ea into sigstore:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants