Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to OIDC discovery #560

Merged
merged 1 commit into from
May 7, 2022
Merged

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented May 6, 2022

Summary

Limit HTTP requests to OIDC discovery endpoints to 10 seconds before
cancelling and returning an error

Ticket Link

Fixes #511

Release Note

* Limited OIDC discovery requests to 10 seconds before timing out

Limit HTTP requests to OIDC discovery endpoints to 10 seconds before
cancelling and returning an error

Signed-off-by: Nathan Smith <nathan@chainguard.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #560 (95c9df9) into main (152c20d) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   36.84%   36.67%   -0.18%     
==========================================
  Files          19       19              
  Lines        1441     1445       +4     
==========================================
- Hits          531      530       -1     
- Misses        851      855       +4     
- Partials       59       60       +1     
Impacted Files Coverage Δ
pkg/config/config.go 51.85% <50.00%> (-0.06%) ⬇️
pkg/ca/fileca/load.go 58.62% <0.00%> (-10.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152c20d...95c9df9. Read the comment docs.

@dlorenc dlorenc merged commit 969e796 into sigstore:main May 7, 2022
@nsmith5 nsmith5 deleted the oidc-timeouts branch May 7, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching OIDC provider configuration does not use timeout
4 participants