Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency properly in File CA implementation #495

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

haydentherapper
Copy link
Contributor

The last fix guarded against writes, but as pointed out in another PR,
the set of certificates could change between fetching the cert/key pair,
and using the cert chain in the response. The fix simply reads the cert
chain and private key once.

Signed-off-by: Hayden Blauzvern hblauzvern@google.com

Summary

Ticket Link

Fixes

Release Note


The last fix guarded against writes, but as pointed out in another PR,
the set of certificates could change between fetching the cert/key pair,
and using the cert chain in the response. The fix simply reads the cert
chain and private key once.

Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
@codecov-commenter
Copy link

Codecov Report

Merging #495 (ab3ea2d) into main (29a36bb) will increase coverage by 0.13%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
+ Coverage   47.84%   47.97%   +0.13%     
==========================================
  Files          14       14              
  Lines        1066     1063       -3     
==========================================
  Hits          510      510              
+ Misses        483      480       -3     
  Partials       73       73              
Impacted Files Coverage Δ
pkg/ca/fileca/fileca.go 35.84% <40.00%> (+1.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a36bb...ab3ea2d. Read the comment docs.

Copy link
Contributor

@nsmith5 nsmith5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah haaa nice catch

@bobcallaway bobcallaway merged commit 765a06a into sigstore:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants