Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: fix sed to update the manifests #466

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 9, 2022

Summary

  • while doing some tests notice the sed is kind of broken and also update the var to use the git tag, which I guess was the initial idea

update the sed to make it work

the error

Step #3: sed -i -e 's;gcr.io/projectsigstore/fulcio:.*;gcr.io/projectsigstore/fulcio:2f2561a0c752aa4c4cafe14dcdb95b4911b01ff8/g' fulcio-v0.2.0.yaml
Step #3: sed: -e expression #1, char 107: unterminated `s' command

after the change and using my docker registry as a name

....
        - name: fulcio-server
          image: ctadeu/fulcio:v0.2.0-1-g2bc6c5a-dirty
          ports:
....

Ticket Link

n/a

Release Note

NONE

Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato requested review from dlorenc and k4leung4 March 9, 2022 08:50
@codecov-commenter
Copy link

Codecov Report

Merging #466 (26c1cd4) into main (2f2561a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   45.66%   45.66%           
=======================================
  Files          14       14           
  Lines         957      957           
=======================================
  Hits          437      437           
  Misses        460      460           
  Partials       60       60           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2561a...26c1cd4. Read the comment docs.

@dlorenc dlorenc merged commit 6eba74e into sigstore:main Mar 9, 2022
@cpanato cpanato deleted the fix-sed branch March 9, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants