Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages returned by SigningCert #388

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Feb 5, 2022

Signed-off-by: Thomas Stromberg t+github@stromberg.org

Summary

This improves error messages returned by SigningCert, specifically adding the URL and status code when an unexpected response code occurs. Currently, if one accidentally points the Fulcio client at a non-Fulcio endpoint, the error message isn't very helpful; particularly when an empty HTTP response body is encountered.

Previous error message

retrieving cert:

New error message

retrieving cert: POST http://localhost:5000/api/v1/signingCert returned 403 Forbidden: ""

Ticket Link

Fixes #387

Release Note

NONE

Signed-off-by: Thomas Stromberg <t+github@stromberg.org>
@dlorenc dlorenc merged commit fa4236e into sigstore:main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client library returns unhelpful error for non-201 responses
2 participants