Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade miekg/pkcs11 library from v1.0.3 to v1.1.1 #376

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Feb 1, 2022

Signed-off-by: Thomas Stromberg t+github@chainguard.dev

Summary

Currently, the fulcio does not build on OpenBSD:

$ go test .
# github.com/miekg/pkcs11
ld: error: unable to find library -ldl

This PR upgrades the miekg/pkcs11 library to a version that compiles cleanly on OpenBSD. Here are the functional PR's included in the miekg/pkcs11 upgrade from v1.0.3:

For a more specific diff, see miekg/pkcs11@v1.0.3...v1.1.1

NOTE: This PR was created using go get github.com/miekg/pkcs11@v1.1.1.

Ticket Link

Fixes #375

Release Note

miekg/pkcs11 dependency upgraded to v1.1.1, improving OpenBSD support.

Signed-off-by: Thomas Stromberg <t+github@chainguard.dev>
@tstromberg tstromberg changed the title Upgrade miekg/pkcs11 dependency from v1.0.3 to v1.1.1 Upgrade miekg/pkcs11 library from v1.0.3 to v1.1.1 Feb 1, 2022
Copy link
Contributor

@nsmith5 nsmith5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! I wonder if we can add some testing to CI to ensure we never regress OpenBSD again. Perhaps add it to the builds in .goreleaser.yml and make a snapshot release in CI or something to check things are at least building on platforms we hope to support?

@dlorenc
Copy link
Member

dlorenc commented Feb 2, 2022

Nice find! I wonder if we can add some testing to CI to ensure we never regress OpenBSD again. Perhaps add it to the builds in .goreleaser.yml and make a snapshot release in CI or something to check things are at least building on platforms we hope to support?

Great idea! Left a note in the tracking issue to tackle that one next.

@dlorenc dlorenc merged commit a02398c into sigstore:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure on OpenBSD: ld: error: unable to find library -ldl
3 participants