Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when an invalid OIDC issuer is provided #357

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

tstromberg
Copy link
Contributor

Signed-off-by: Thomas Stromberg t+github@chainguard.dev

Summary

This PR improves the error message output when the OIDC Issuer URL is not valid. For example, with this command-line: fulcio serve --ca=pkcs11ca --hsm-caroot-id=1 --ct-log-url=http://localhost:6105/sigstore --host=0.0.0.0 --port=5000

Old output

FATAL app/serve.go:130 error loading config: 404 Not Found: 404 page not found

New output

FATAL app/serve.go:131 error loading --config-path=/etc/fulcio-config/config.json: provider http://localhost:5556/auth: 404 Not Found: 404 page not found

Release Note

NONE

Signed-off-by: Thomas Stromberg <t+github@chainguard.dev>
@dlorenc dlorenc merged commit a165f5c into sigstore:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants