Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support intermediate CA with fileca backend #320

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented Jan 8, 2022

Summary

Adds support for an intermediate CA using the fileca backend

Ticket Link

Fixes #300

Release Note

* Added support for intermediate CA to the `fileca` backend

@nsmith5 nsmith5 force-pushed the fileca-intermediates branch 4 times, most recently from 44ae553 to bb427eb Compare January 8, 2022 06:12
pkg/ca/fileca/load.go Show resolved Hide resolved
pkg/ca/fileca/load.go Show resolved Hide resolved
@nsmith5
Copy link
Contributor Author

nsmith5 commented Jan 11, 2022

Thanks for the timely review @haydentherapper! I'll add the len(chain) = 3 test case and modify the cert verification logic soon :D

@nsmith5 nsmith5 force-pushed the fileca-intermediates branch 2 times, most recently from 6b1589e to cc60c9d Compare January 15, 2022 21:56
@dlorenc
Copy link
Member

dlorenc commented Jan 15, 2022

The codeql check is failing everywhere, so you can ignore that one!

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for adding all of the comprehensive tests!

@nsmith5
Copy link
Contributor Author

nsmith5 commented Jan 17, 2022

Sweeeet! Thanks for the comprehensive review. It really taught me a lot! I really appreciate the time you put into it ❤️

Copy link
Member

@bobcallaway bobcallaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change to drive re-use but otherwise LGTM

pkg/ca/fileca/fileca.go Outdated Show resolved Hide resolved
Signed-off-by: Nathan Smith <nathan@nfsmith.ca>
@dlorenc dlorenc merged commit f024a03 into sigstore:main Jan 21, 2022
@nsmith5 nsmith5 deleted the fileca-intermediates branch January 21, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CA chain in fileca
4 participants