Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make client request timeout configurable with WithTimeout client option #272

Merged
merged 2 commits into from
Dec 11, 2021

Conversation

nsmith5
Copy link
Contributor

@nsmith5 nsmith5 commented Dec 11, 2021

Summary

Adds a client request timeout option. This closes #266.

Also adds vim swap files to the gitignore. Can drop this if folks think its not relevant to the PR or repository.

Release Note

* Added `WithTimeout` client option to configure request timeout

Signed-off-by: Nathan Smith <nathan@nfsmith.ca>
Signed-off-by: Nathan Smith <nathan@nfsmith.ca>
@mattmoor mattmoor merged commit e270bd4 into sigstore:main Dec 11, 2021
@nsmith5 nsmith5 deleted the ns/client-timeout branch December 12, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClientOption for specifying request timeout
2 participants