Drop gratuitous sync.Once in google CAs.
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This threads `cmd.Context()` into the constructor, and has it call the client constructor directly. Previously the caller was already wrapped in a `sync.Once`, but not this is all called once from the command's `Run` method. Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
mattmoor
force-pushed
the
remove-sync-once
branch
from
1dda036 to
6b68a73
Compare
mattmoor
changed the title
sync.Once in google CAs.sync.Once in google CAs.
|
cc @n3wscott |
bobcallaway
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This threads
cmd.Context()into the constructor, and has it call the client constructor directly. Previously the caller was already wrapped in async.Once, but not this is all called once from the command'sRunmethod.WIP until #257 merges.
Signed-off-by: Matt Moore mattmoor@chainguard.dev
Ticket Link
N/A
Release Note