Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github to fulcioca path. #184

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Add Github to fulcioca path. #184

merged 1 commit into from
Sep 14, 2021

Conversation

mattmoor
Copy link
Member

Fixes: #183
Signed-off-by: Matt Moore mattomata@gmail.com

Fixes: sigstore#183
Signed-off-by: Matt Moore <mattomata@gmail.com>
@mattmoor
Copy link
Member Author

cc @lukehinds

@cpanato cpanato added this to the 0.2.0 milestone Sep 14, 2021
Copy link
Member

@lukehinds lukehinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, did you manage to test at all, I can help getting softhsm working if needed?

@mattmoor
Copy link
Member Author

Haven't tested, this was sort of a guess. If there are good instructions somewhere I can perhaps try later, but I gotta put together a demo for the meeting first 😅

@lukehinds lukehinds merged commit 546e5a3 into sigstore:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub OCI requires implementation for fulcio CA
3 participants