-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script and process to generate OIDC config from federation directory. #139
Conversation
ec5a007
to
c624067
Compare
TODO:
|
eb26809
to
4d17ae5
Compare
Ref #122 |
"https://oidc.dlorenc.dev": { | ||
"IssuerURL": "https://oidc.dlorenc.dev", | ||
"ClientID": "sigstore", | ||
"Type": "spiffe" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is the main default server config, could there be a fulcio-federated-config.yaml that is used for other specific providers? It could be under federated/config maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it down a directory! How's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see that, it still seems to be in the main config.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this file is actually generated now (and there's a test to make sure its up to date). The full merged list needs to be in one place. The user-edited ones are now in federation/ and federation/external.
Signed-off-by: Dan Lorenc <dlorenc@google.com>
Signed-off-by: Dan Lorenc dlorenc@google.com