Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Issuer interface for username and uri Issuer types #1035

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

priyawadhwa
Copy link
Contributor

No description provided.

Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Merging #1035 (f5313ed) into main (123d011) will increase coverage by 0.26%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
+ Coverage   53.82%   54.08%   +0.26%     
==========================================
  Files          41       45       +4     
  Lines        2430     2470      +40     
==========================================
+ Hits         1308     1336      +28     
- Misses       1026     1034       +8     
- Partials       96      100       +4     
Impacted Files Coverage Δ
pkg/identity/kubernetes/issuer.go 70.00% <70.00%> (ø)
pkg/identity/spiffe/issuer.go 70.00% <70.00%> (ø)
pkg/identity/uri/issuer.go 70.00% <70.00%> (ø)
pkg/identity/username/issuer.go 70.00% <70.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@priyawadhwa priyawadhwa merged commit e5beb02 into sigstore:main Mar 2, 2023
@priyawadhwa priyawadhwa deleted the more-issuers branch March 2, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants