Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail fast if private key is not found when using PKCS11 CA #284

Closed
rgerganov opened this issue Dec 16, 2021 · 0 comments · Fixed by #285
Closed

Fail fast if private key is not found when using PKCS11 CA #284

rgerganov opened this issue Dec 16, 2021 · 0 comments · Fixed by #285
Labels
bug Something isn't working

Comments

@rgerganov
Copy link
Contributor

When Fulcio is using pkcs11, it expects a private key under the "PKCS11CA" label. If there is no such key, Fulcio starts successfully but fails on the first signing request. A much better behavior is to fail fast and inform the user that the private key is not found upon start.
@rgerganov rgerganov added the bug Something isn't working label Dec 16, 2021
rgerganov pushed a commit to rgerganov/fulcio that referenced this issue Dec 16, 2021
Fail fast if private key is not found when using PKCS11 CA
01cad96 
When Fulcio is using pkcs11, it expects a private key under the
"PKCS11CA" label. If there is no such key, Fulcio starts successfully
but fails on the first signing request. A much better behavior is to
fail fast and inform the user that the private key is not found upon
start.

Closes: sigstore#284

Signed-off-by: Radoslav Gerganov <rgerganov@vmware.com>
@rgerganov rgerganov mentioned this issue Dec 16, 2021
Merged
dlorenc pushed a commit that referenced this issue Dec 16, 2021
@rgerganov
Fail fast if private key is not found when using PKCS11 CA (#285)
98dbae6 
When Fulcio is using pkcs11, it expects a private key under the
"PKCS11CA" label. If there is no such key, Fulcio starts successfully
but fails on the first signing request. A much better behavior is to
fail fast and inform the user that the private key is not found upon
start.

Closes: #284

Signed-off-by: Radoslav Gerganov <rgerganov@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail fast if private key is not found when using PKCS11 CA rgerganov/fulcio
1 participant
@rgerganov