Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to OCI media types. #39

Closed
wants to merge 1 commit into from
Closed

Switch to OCI media types. #39

wants to merge 1 commit into from

Conversation

dlorenc
Copy link
Member

@dlorenc dlorenc commented Mar 2, 2021

No description provided.

Signed-off-by: Dan Lorenc <dlorenc@google.com>
@cpanato cpanato added this to the 0.3.0 milestone Apr 3, 2021
@dlorenc
Copy link
Member Author

dlorenc commented Apr 6, 2021

cc @jdolitsky we should figure out how to get this in.

@dlorenc
Copy link
Member Author

dlorenc commented Apr 6, 2021

Would it make sense to register a media type somewhere?

@jdolitsky
Copy link
Contributor

Strictly speaking, the OCI artifacts project says to register one with IANA. In reality, I don't know of any project has gone through with that process..

That being said, I do think it makes sense for this project to define a custom mediatype. See https://github.com/opencontainers/artifacts/blob/master/artifact-authors.md#defining-a-unique-artifact-type

So something along the lines of:

application/vnd.sigstore.cosign.config.v1+json

This could just be published in the cosign docs somewhere.

For registries that only allow Docker, perhaps provide a bool flag such as --as-docker, or make it even more customizable with a string flag/env var.

@dlorenc
Copy link
Member Author

dlorenc commented May 5, 2021

We fixed this in #300

@dlorenc dlorenc closed this May 5, 2021
@dlorenc dlorenc deleted the mt branch May 5, 2021 00:18
tommyd450 pushed a commit to tommyd450/cosign that referenced this pull request Oct 26, 2023
chore: modify update script to avoid merge conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants