Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set go to min 1.21 and update dependencies #3327

Merged
merged 6 commits into from
Oct 29, 2023
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 27, 2023

Summary

  • Set go to min 1.21 and update dependencies

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #3327 (293cebe) into main (9400476) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3327      +/-   ##
==========================================
+ Coverage   30.31%   30.32%   +0.01%     
==========================================
  Files         155      155              
  Lines        9919     9921       +2     
==========================================
+ Hits         3007     3009       +2     
  Misses       6462     6462              
  Partials      450      450              
Files Coverage Δ
pkg/cosign/kubernetes/secret.go 37.34% <100.00%> (ø)
pkg/oci/mutate/mutate.go 91.45% <100.00%> (+0.08%) ⬆️

bobcallaway
bobcallaway previously approved these changes Oct 28, 2023
bobcallaway
bobcallaway previously approved these changes Oct 28, 2023
bobcallaway
bobcallaway previously approved these changes Oct 28, 2023
@@ -117,5 +117,5 @@ func (c *TSAClient) GetTimestampResponse(tsq []byte) ([]byte, error) {
tsStruct.Time = c.Time
}

return tsStruct.CreateResponse(c.CertChain[0], c.Signer)
return tsStruct.CreateResponseWithOpts(c.CertChain[0], c.Signer, hashAlg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different hash algs, this is for generating the hash for the signed timestamp structure. Let’s just hardcode to sha256

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, thanks

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@bobcallaway bobcallaway merged commit 173f547 into sigstore:main Oct 29, 2023
28 checks passed
@github-actions github-actions bot added this to the v2.3.0 milestone Oct 29, 2023
@cpanato cpanato deleted the updates branch October 29, 2023 16:33
@cpanato cpanato removed this from the v2.3.0 milestone Nov 16, 2023
@cpanato cpanato added this to the v2.2.1 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants