Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guard flag for experimental OCI 1.1 verify. #3272

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Oct 3, 2023

Summary

Previously the experimental behaviour for verify defaulted to using experimental OCI 1.1 behvaiour. This seems to cause some problems with some registries. So default that behaviour to false, and you have to explicitly enable it with a flag.
Also, by adding it to checkopts, we can now flip this on/off for clients like policy-controller where the problems surfaced.

Release Note

Documentation

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #3272 (1f9dd4c) into main (5ed63e0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3272      +/-   ##
==========================================
- Coverage   30.32%   30.31%   -0.02%     
==========================================
  Files         155      155              
  Lines        9853     9858       +5     
==========================================
  Hits         2988     2988              
- Misses       6418     6423       +5     
  Partials      447      447              
Files Coverage Δ
cmd/cosign/cli/verify/verify.go 21.20% <0.00%> (-0.07%) ⬇️
cmd/cosign/cli/options/verify.go 0.00% <0.00%> (ø)
pkg/cosign/verify.go 34.57% <0.00%> (-0.04%) ⬇️

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hectorj2f hectorj2f merged commit 5b2d30a into sigstore:main Oct 11, 2023
28 checks passed
@github-actions github-actions bot added this to the v2.3.0 milestone Oct 11, 2023
@cpanato cpanato modified the milestones: v2.3.0, v2.2.1 Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants