-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ability to get image digest back via triangulate #3255
Conversation
@garethahealy Thanks for the PR! Looks good, can you rebase and add a comment that demonstrates this in use? |
rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Codecov Report
@@ Coverage Diff @@
## main #3255 +/- ##
=======================================
Coverage 30.65% 30.65%
=======================================
Files 155 155
Lines 9989 9994 +5
=======================================
+ Hits 3062 3064 +2
- Misses 6471 6474 +3
Partials 456 456
|
Can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Not sure why linter is failing, trying to rerun
@cpanato Any guesses why the linter is complaining? we're using the latest golangci-lint version |
Signed-off-by: Gareth Healy <garethahealy@gmail.com>
@haydentherapper ; ran linting locally that highlighted an indenting issue - fixed and pushed, hopefully that fixes linting. green on my fork: |
it is all good on the ci side :) |
Summary
Provides the ability to resolve digest for image without the need to use another tool, such as crane/skopeo
Fixes #3034
Documentation
CLI provides self-documentation via extra option on flag.