remove GODEBUG: x509sha1=1 setting for e2e tests #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry S <dsavints@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2931 +/- ##
=======================================
Coverage 30.32% 30.32%
=======================================
Files 151 151
Lines 9451 9451
=======================================
Hits 2866 2866
Misses 6140 6140
Partials 445 445 |
imjasonh
approved these changes
Apr 26, 2023
hectorj2f
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR removes one
GODEBUG: x509sha1=1setting which is no longer needed.Related issue: #2091
/cc @haydentherapper @imjasonh
Release Note
NONE
Documentation
no changes