Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.cosign -> .sig #287

Merged
merged 1 commit into from
Apr 30, 2021
Merged

.cosign -> .sig #287

merged 1 commit into from
Apr 30, 2021

Conversation

dekkagaijin
Copy link
Member

Fixes #249

Signed-off-by: Jake Sanders jsand@google.com

@dlorenc
Copy link
Member

dlorenc commented Apr 29, 2021

Looks like you missed one test.

@dekkagaijin
Copy link
Member Author

whoops...

Copy link
Member

@dlorenc dlorenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure this one makes it into the CHANGELOG.md too.

Signed-off-by: Jake Sanders <jsand@google.com>
@dekkagaijin
Copy link
Member Author

We should make sure this one makes it into the CHANGELOG.md too.

how's this?

@dekkagaijin dekkagaijin merged commit e96653f into sigstore:main Apr 30, 2021
@dekkagaijin dekkagaijin deleted the sig branch April 30, 2021 04:02
youssefazrak added a commit to youssefazrak/cosigned that referenced this pull request May 19, 2021
PR sigstore/cosign#287 changed the signature
extension from .cosign to .sig.

As we are using Cosign:v0.2.0, the manager was not able anymore to fetch
signatures signed with latest version of Cosign.

Fixes: dlorenc#3

Signed-off-by: Youssef Azrak <yazrak.tech@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec: Replace .cosign with .sig in the suffix
2 participants