-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support sign-blob with certificate #2636
Conversation
4799499
to
0f16131
Compare
Codecov Report
@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
- Coverage 30.03% 29.96% -0.08%
==========================================
Files 146 146
Lines 9283 9305 +22
==========================================
Hits 2788 2788
- Misses 6065 6087 +22
Partials 430 430
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0f16131
to
7b724dc
Compare
@asraa and @haydentherapper I think the small refactor here to add the Cert and CertChain to Line 73 in e69e190
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll let @asraa approve since she's mostly worked in this part of the codebase
Adds support for `--certificate` and `--certificate-chain` to the sign-blob command. Fixes sigstore#2635 Signed-off-by: Nathan Smith <nathan@nfsmith.ca>
7b724dc
to
2769376
Compare
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been stalled for 10 days with no activity. |
Summary
The
verify-blob
and every other signing command all allow folks to specify a custom x509 cert and chain to sign with. This work adds support for specifying the cert and CA chain for thesign-blob
command as it was missing.As specifying a certificate and cert chain is supported in all signing and verifying commands this work also refactors our
options.KeyOpt
struct to move the certificate details there. This makes the passing of these details to initialize a signer the same for all commands.Fixes #2635
Release Note
sign-blob
with the--certificate
and--certificate-chain
flagsDocumentation
Added docs in
/docs
and in CLI options. Can follow up with a PR to docs.sigstore.dev if folks feel we need an example over there.