Fix missing privacy statement, print in multiple locations #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The statement wasn't being printed, only the confirmation, so updated that and its spacing. Additionally, I added the statement to be printed before using Fulcio in addition to Rekor. It'll only be printed once since we use sync.Once. The motivation for this is that Fulcio includes the certificate in its own CT log, so users should be prompted before. Otherwise, by the time they would say no to the Rekor prompt, the email would already be publicly logged. Updates to sigstore#2580 Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
asraa
approved these changes
Jan 12, 2023
znewman01
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statement wasn't being printed, only the confirmation, so updated that and its spacing.
Additionally, I added the statement to be printed before using Fulcio in addition to Rekor. It'll only be printed once since we use sync.Once. The motivation for this is that Fulcio includes the certificate in its own CT log, so users should be prompted before. Otherwise, by the time they would say no to the Rekor prompt, the email would already be publicly logged.
Updates to #2580
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Summary
Release Note
Documentation