Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add enhanced error messages for failing verification with TUF targets #2589

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Jan 3, 2023

Fixes #2588

This adds some detailed erorr messages when a matching Rekor/CT key is not found for a target or when certificate chain validation fails. This points users to checking their TUF roots or giving the alternative to set a custom trusted key.

Note: I cannot do this validation before actually inspecting the artifact that needs to be validated, so these errors are inside the verification stack (and not at TUF target collection)

Signed-off-by: Asra Ali asraa@google.com

Summary

Release Note

Documentation

…rgets

Signed-off-by: Asra Ali <asraa@google.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #2589 (89ea82a) into main (59921bb) will increase coverage by 0.03%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##             main    #2589      +/-   ##
==========================================
+ Coverage   30.80%   30.84%   +0.03%     
==========================================
  Files         144      144              
  Lines        8736     8741       +5     
==========================================
+ Hits         2691     2696       +5     
  Misses       5654     5654              
  Partials      391      391              
Impacted Files Coverage Δ
pkg/cosign/tlog.go 39.19% <0.00%> (ø)
pkg/cosign/verify_sct.go 50.58% <85.71%> (+3.08%) ⬆️
pkg/cosign/verify.go 39.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@asraa asraa merged commit 3ed2056 into sigstore:main Jan 4, 2023
@github-actions github-actions bot added this to the v1.14.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enchancement: Keyless Cosign Verify error statement
3 participants